Improving return types of action creators by adding generic args type #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @salguerooo. Sorry for my delayed response. Is there any backward compatibility issue that we should be aware of? |
|
Hey @supasate, Hmm there might be if someone is implementing the CallHistoryMethodAction and LocationActionPayload interfaces, I can't find a reason anyone would do that, but one way of making it backwards compatible would be to default those generics to any, something like Should I do the change? |
|
Hey @supasate, I made the changes, what do you think? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this is to have better autocomplete on the created actions.
It seems like a very niche use, but I ran into it and would like to have better autocompletes.
Also improves the LocationState type inside LocationDescriptorObject, before it was aways
any.